chore(angular, react): update dependencies for swiper branch #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
changed the title
liamdebeasi
commented
Mar 23, 2023
Comment on lines
+15
to
+17
| import 'swiper/css/keyboard'; | ||
| import 'swiper/css/pagination'; | ||
| import 'swiper/css/scrollbar'; |
There was a problem hiding this comment.
We can do these imports with React Scripts v5. I'll update the migration guide. This app was using React Scripts v4 which is why we did the direct imports.
liamdebeasi
commented
Mar 23, 2023
Comment on lines
-23
to
-25
| const options = { | ||
| keyboard: true | ||
| }; |
There was a problem hiding this comment.
This wasn't being used anywhere
averyjohnston
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial implementation of FW-3758. Vue has peer dependency issues that will be handled in a separate PR.
Angular Changes:
React Changes:
index.tsxupdate for mounting)