Skip to content

chore(angular, react): update dependencies for swiper branch #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 27, 2023

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Mar 23, 2023

This is a partial implementation of FW-3758. Vue has peer dependency issues that will be handled in a separate PR.

Angular Changes:

  1. Angular 15 (and associated deps)
  2. Latest Ionic v6

React Changes:

  1. React 18 (and index.tsx update for mounting)
  2. Latest React Router v5
  3. Latest Ionic v6
  4. Latest Ionicons v6
  5. React Scripts v5

@liamdebeasi liamdebeasi changed the title Angular update chore(angular, react): update dependencies for swiper branch Mar 23, 2023
Comment on lines +15 to +17
import 'swiper/css/keyboard';
import 'swiper/css/pagination';
import 'swiper/css/scrollbar';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do these imports with React Scripts v5. I'll update the migration guide. This app was using React Scripts v4 which is why we did the direct imports.

@liamdebeasi liamdebeasi requested a review from a team March 23, 2023 19:39
@liamdebeasi liamdebeasi marked this pull request as ready for review March 23, 2023 19:39
Comment on lines -23 to -25
const options = {
keyboard: true
};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't being used anywhere

@liamdebeasi liamdebeasi merged commit bdd7ac6 into swiper Mar 27, 2023
@liamdebeasi liamdebeasi deleted the angular-update branch March 27, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants