fix(angular): variables gets loaded after global #1834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the issues I'm seeing devs run into with the Ionic 8 beta is with trying to override the default light theme. Devs are placing their overrides in
theme/variables.scss. However, ourangular.jsonconfig has it so thattheme/variables.scssis loaded beforeglobal.scss(where the default light theme is imported).Since both sets of styles target the same selector, they have the same specificity and the latest style to get added to the DOM wins (
global.scssin this case). As a result, the custom styles do not apply.This PR switches the order so
global.scssis loaded first. This is really only needed for Ionic 8, so I could target thefeature-8.0branch. However, I figured it would be good to get this change out sooner since devs testing the Ionic 8 beta may create fresh apps.