Skip to content

lib targeting netstandard2.0 parse ok but intellisense fails #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
enricosada opened this issue Jul 4, 2017 · 12 comments
Closed

lib targeting netstandard2.0 parse ok but intellisense fails #180

enricosada opened this issue Jul 4, 2017 · 12 comments
Labels
bug

Comments

@enricosada
Copy link
Contributor

enricosada commented Jul 4, 2017 •
edited
Loading

repro:

Using sdk 2.0.0-preview2

dotnet new lib -lang f#

the build is ok (bugfix is already in), but FCS is not

Fixed in compiler with dotnet/fsharp#3215

need to refresh FCS (after that bugfix is merged)

/cc @NinoFloris
@enricosada enricosada added the bug label Jul 4, 2017
@dsyme
Copy link
Contributor

dsyme commented Jul 6, 2017

@enricosada There's a nasty integration to complete from fsharp --> FSharp.Compiler.Service. After that, this is easy

@enricosada
Copy link
Contributor Author

sigh. there is a scoreboard for single repo vs separated? dunno what options is winning atm 😭
thx a lot @dsyme for these continued alignment.

@dsyme dsyme mentioned this issue Jul 6, 2017
Closed
@dsyme
Copy link
Contributor

dsyme commented Jul 6, 2017

sigh. there is a scoreboard for single repo vs separated? dunno what options is winning atm

yeah I know. I can really see the argument for maintaining independence though

@enricosada
Copy link
Contributor Author

yes, i try to reconsider side from time to time too, but atm i am strongly on maintaining independence side (but just because you lose lot of time doing alignment, i know is taxing)

@enricosada enricosada mentioned this issue Jul 7, 2017
Closed
@dsyme
Copy link
Contributor

dsyme commented Jul 7, 2017

but just because you lose lot of time doing alignment, i know is taxing

I wish we could automate this more easily

@ian-moore ian-moore mentioned this issue Aug 1, 2017
Closed
@Krzysztof-Cieslak Krzysztof-Cieslak mentioned this issue Aug 16, 2017
Closed
@enricosada enricosada mentioned this issue Aug 16, 2017
Closed
@matthid matthid mentioned this issue Aug 18, 2017
Closed
@ninjarobot ninjarobot mentioned this issue Aug 18, 2017
Closed
@dsyme dsyme mentioned this issue Aug 22, 2017
Closed
@dsyme
Copy link
Contributor

dsyme commented Aug 23, 2017

SHould be fixed in FCS 14.0.1

There may have been significant changes in the FCS API in 14.0.1 - please check and let me know if upgrading FsAutoCOmplete.exe goes ok fsharp/fsharp-compiler-docs#792

@Krzysztof-Cieslak
Copy link
Member

@dsyme, has anything important changed about GetDeclarationListInfo (maybe 1-based vs 0-based indexing ?) It's the only thing that completely fails FSAC test suite after upgrading to new FCS

@dsyme
Copy link
Contributor

dsyme commented Aug 25, 2017 •
edited
Loading

@dsyme, has anything important changed about GetDeclarationListInfo (maybe 1-based vs 0-based indexing ?) It's the only thing that completely fails FSAC test suite after upgrading to new FCS

@Krzysztof-Cieslak Not that I know of, but there have been quite a few changes. We removed the Alternate from some names for example

What's the failure? It's possible it's a fix not a failure. Or it's possible it's a freshly introduced mistake

The Visual F# Tools do use this method here and here, so it is under pretty strong test, but that's not to say it's not an introduced bug

@dsyme
Copy link
Contributor

dsyme commented Aug 25, 2017

@Krzysztof-Cieslak If you could submit a PR I could take a look at the failure logs

@Krzysztof-Cieslak
Copy link
Member

@dsyme, I've already found an issue - it's breaking change in tokenizer (FSharpTokenColorKind of . used to be Operator and it has changed ) which resulted in Lexer going crazy and passing wrong long ident table to the GetDeclarationListInfo.

@Krzysztof-Cieslak
Copy link
Member

The PR is here - #196, there are still some failing tests but those are rather minimal changes, everything seems to work OK

enricosada added a commit to enricosada/FsAutoComplete that referenced this issue Aug 30, 2017
@enricosada
reenable test DotNetSdk2.0Crossgen
8122cb5 
the errors are because ionide#180
after that is fixed, is expected to have `"Errors:" []`
enricosada added a commit that referenced this issue Aug 30, 2017
@enricosada
fix ci, .net core 2.0 RTM, normalize fsprojs (#197)
6e4e4b3 
- normalize project files to vs 2013, so works with vs 2017 too
- use dotnet install script to install both .net core 1.0 and 2.0, so also 1.0 is pinned

## Test Suite

- skip test `ProjectCache/Runner.fsx`, if executed in appveyor, in the fake script
- reenable test DotNetSdk2.0Crossgen

    the errors are because #180
    after that is fixed, is expected to have `"Errors:" []`

- workaround an fsc bug so test pass on mono 5.x (ref fsharp/fsharp#774)

## Appveyor

- build on appveyor using vs 2015 and 2017 images

## Travis

- add mono 5.2.0 to travis build matrix
This was referenced Aug 30, 2017
Closed
Merged
@enricosada
Copy link
Contributor Author

Closing. fixed with #200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@enricosada @Krzysztof-Cieslak @dsyme