Skip to content

use FSharp.Compiler.Tools, fixes #184 #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

0x53A
Copy link

@0x53A 0x53A commented Jul 14, 2017

fixes #184

This replaces the in-box compiler with the nuget FSharp.Compiler.Tools and so makes it independent of the version of VS installed. You still need some version of VS for msbuild, etc.

Let's see what the CI says...

Lukas Rieger added 2 commits July 14, 2017 22:19
replace
  <FSharpTargetsPath>
with
  <FSharpTargetsPath Condition=" '$(FSharpTargetsPath)' == '' ">
@0x53A
Copy link
Author

0x53A commented Jul 14, 2017

home/travis/build/fsharp/FsAutoComplete/packages/FSharp.Compiler.Tools/tools/Microsoft.FSharp.Targets: error : Tool executable '/home/travis/build/fsharp/FsAutoComplete/src/FsAutoComplete.Core/../tools/fsc.exe' could not be found

The first travis failure looks a bit like a xbuild bug, the two after that have a failed integration test :\

@enricosada
Copy link
Contributor

@0x53A sry, this need a rebase

i normalized the fsprojs to vs2013 format with #197 so now works ok up to vs2017 (fixing#184 too) without the FSharp.Compiler.Tools package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails due to missing VisualStudioVersion
3 participants