Skip to content

Prevent players and servers from printing non-printable characters to the terminal #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rdntcntrl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prevent players and servers from printing non-printable characters to the terminal #826

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions code/sys/sys_main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,15 +433,41 @@ void Sys_AnsiColorPrint( const char *msg )
}
}

/*
=================
Sys_ReplaceNonPrintableChars
=================
*/
void Sys_ReplaceNonPrintableChars(char *str)
{
char *p;

for (p = str; *p != '\0'; p++)
{
if ( !isprint(*p) && *p != '\n' )
{
*p = '.';
}
}
}

/*
=================
Sys_Print
=================
*/
void Sys_Print( const char *msg )
{
CON_LogWrite( msg );
CON_Print( msg );
char clean_msg[ MAXPRINTMSG ];

// Replace non-printable characters before we print the string
// Prevents abuse, e.g. players messing up the terminal by \say-ing
// escape sequences
Q_strncpyz(clean_msg, msg, sizeof(clean_msg));
Sys_ReplaceNonPrintableChars(clean_msg);

CON_LogWrite( clean_msg );
CON_Print( clean_msg );
}

/*
Expand Down
Loading