Skip to content
This repository was archived by the owner on Aug 23, 2020. It is now read-only.

Fixed and added javadoc comments for existing classes#1026

Merged
GalRogozinski merged 8 commits intoiotaledger-archive:devfrom
legacycode:dev-add-javadoc
Jan 29, 2019
Merged

Fixed and added javadoc comments for existing classes#1026
GalRogozinski merged 8 commits intoiotaledger-archive:devfrom
legacycode:dev-add-javadoc

Conversation

@legacycode
Copy link
Copy Markdown
Contributor

Description

I fixed some javadoc tags and added documentation to existing classes.

Type of change

  • Documentation Fix

How Has This Been Tested?

  • mvn clean install

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

@iotaledger-archive iotaledger-archive deleted a comment Oct 2, 2018
Copy link
Copy Markdown
Contributor

@GalRogozinski GalRogozinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for @kwek20 to validate the mdx file

@kwek20
Copy link
Copy Markdown
Contributor

kwek20 commented Oct 7, 2018

@GalRogozinski I Ran MDX, Runs fine! Docs are normal.
@see of a response is not used in the MDX generation.

@alon-e alon-e changed the title Fixed and added javadoc comments for exiting classes Fixed and added javadoc comments for existing classes Nov 11, 2018
@GalRogozinski GalRogozinski requested a review from kwek20 November 20, 2018 08:33
@kwek20
Copy link
Copy Markdown
Contributor

kwek20 commented Nov 20, 2018

@GalRogozinski

@see will be used in the v2 of the Doclet to pickup fields of the referenced class, so the list is no longer required when we run it. Since we're not ready with that yet, Ill remove the list in that annotation/v2 PR, this is okay for now.

@legacycode
Copy link
Copy Markdown
Contributor Author

@GalRogozinski could you please merge this PR or are there any task for me?

@GalRogozinski
Copy link
Copy Markdown
Contributor

Hey @legacycode

Sorry for not responding, we were at a race to release Local Snapshots before Christmas (as you have noticed did not happen).

After Local Snapshots will be released we will start to sweep over the PRs and merge them.
I would have merged this now if it wasn't for the conflict to be honest.

If you want some small tasks you can do #1231, #1232, #930, or #1221.
If you want a more challenging task do #1090 (best as an IXI).

I can think of other tasks but they need to be properly groomed before.
We will talk after Christmas :-)

@legacycode
Copy link
Copy Markdown
Contributor Author

@GalRogozinski will this be merged? its from September and approved.

@jakubcech
Copy link
Copy Markdown
Contributor

@kwek20 is this good to go from your PoV (yes I see that you approved above 😺)? And any dependencies with regards to your doclet work, like #1155?

@kwek20
Copy link
Copy Markdown
Contributor

kwek20 commented Jan 28, 2019

@jakubcech This is still valid, as were still waiting for the next release of maven-javadoc-plugin before releasing the new doclet. Can be merged!

@GalRogozinski GalRogozinski merged commit 91d8f7c into iotaledger-archive:dev Jan 29, 2019
@legacycode legacycode deleted the dev-add-javadoc branch February 14, 2019 18:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants