This repository was archived by the owner on Aug 23, 2020. It is now read-only.
Refactor: Removed grace time from solid entry points generation#1199
Merged
GalRogozinski merged 2 commits intoiotaledger-archive:dev-localsnapshotsfrom Nov 29, 2018
Merged
Conversation
hmoog
changed the title
| if (sendQueue.remainingCapacity() == 0) { | ||
| sendQueue.poll(); | ||
| log.info("Sendqueue full...dropped 1 tx"); | ||
| log.debug("Sendqueue full...dropped 1 tx"); |
Contributor
There was a problem hiding this comment.
I found this info statement very useful while trying to peer nodes and noticing right away that there is a problem.
I agree it is very annoying the way it can flood the console.
Maybe use the IntervalLogger?
Author
There was a problem hiding this comment.
We already have the connection message for this case. In case a node drops the connection or doesnt accept packets (like with NELSON) you will not see anything in your cli.
Contributor
Maybe we do this change when we start applying the cuckoo filter? |
GalRogozinski
approved these changes
Nov 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the grace time from the solid entry points generation. It was added in the past to work around the back referencing transaction issue. Since the issue can not be solved by just keeping the solid entry points alive for a little longer time and needs to be addressed separately (we will use cuckoo filters for this later on), it can and should be removed.
Especially in scenarios where we have a lot of TPS and a side tangle (like it happened today) it can slow the snapshot generation noticable and disrupt the operation of the node.
Note: This PR also changes the info message when the sendqueue is full to being a debug message because it can otherwise spam the CLI output making it very hard to debug problems and see important messages of the console output.
Type of change
Checklist: