This repository was archived by the owner on Aug 23, 2020. It is now read-only.
Fix: added a buffer to LSManager#1286
Merged
GalRogozinski merged 2 commits intoiotaledger-archive:devfrom Jan 30, 2019
Merged
Conversation
GalRogozinski
suggested changes
Jan 17, 2019
src/main/java/com/iota/iri/service/snapshot/impl/LocalSnapshotManagerImpl.java
Show resolved
Hide resolved
src/main/java/com/iota/iri/service/snapshot/impl/LocalSnapshotManagerImpl.java
Show resolved
Hide resolved
GalRogozinski
approved these changes
Jan 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To prevent jumping back and forth in and out of sync, there is now a buffer in between.
Only when the latest milestone and latest snapshot differ more than this number, we fall out of sync
Fixes #1209
Type of change
How Has This Been Tested?
Not yet tested, will request a node as soon as possible.
submitting the PR to start possible discussion about the implementation
Checklist: