This repository was archived by the owner on Aug 23, 2020. It is now read-only.
zmq: only write to socket from one thread#569
Merged
GalRogozinski merged 3 commits intoiotaledger-archive:devfrom Mar 6, 2018
Merged
zmq: only write to socket from one thread#569GalRogozinski merged 3 commits intoiotaledger-archive:devfrom
GalRogozinski merged 3 commits intoiotaledger-archive:devfrom
Conversation
Contributor
Author
|
Both internal & community users reported no more ZMQ outages. |
GalRogozinski
suggested changes
Mar 5, 2018
| try { | ||
| publisherService.awaitTermination(5, TimeUnit.SECONDS); | ||
| } catch (InterruptedException e) { | ||
| e.printStackTrace(); |
Contributor
There was a problem hiding this comment.
Shouldn't this be printed with a logger?
| } catch (InterruptedException e) { | ||
| e.printStackTrace(); | ||
| } | ||
| publisher.close(); |
Contributor
There was a problem hiding this comment.
Since there is a try I find it more readable to put the last two lines in a finally block.
GalRogozinski
approved these changes
Mar 5, 2018
GalRogozinski
approved these changes
Mar 5, 2018
This was referenced Apr 16, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zeromq is not thread safe to use.
Hence, the Socket should only be used from within one thread.