This repository was archived by the owner on Jun 2, 2020. It is now read-only.
Move "edit this page in GitHub" link to near feedback buttons per #305 #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change old FAQ sidebar link to "Forum FAQ Archive"
|
@jessicaschilling can i ask you to paste a screenshot of the change here, for visual review? 🙏 😬 |
|
Sweet thx! |
ericronne
approved these changes
Oct 21, 2019
cwaring
approved these changes
Oct 21, 2019
|
Thanks both - and I'll be better on screenshots in the future. 😉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #305 ...
Also totally accidentally pushed a change in old FAQ sidebar link to "Forum FAQ Archive". Apologies for the topical mismatch in a single PR.
Closes #305
(since implementation of those mockups in the beta site is happening in #306)