Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

Add files with progress callback - called 58 times? #193

Closed
@alanshaw

Description

@alanshaw

https://github.com/ipfs/interface-ipfs-core/blob/master/src/files.js#L115

Just wondering where there 58 comes from and what it's testing? I think it might be a brittle check as it's probably determined by data storage/transfer in much deeper dependencies that these tests have no control over.

It might work for now (and on the systems the tests are run on) but break later. I think it's enough to check that the progress function was called at least once and that the reported progress bytes is equal to the total bytes uploaded.

Would you accept a PR for this change?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions