Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

Pubsub message fields #169

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Pubsub message fields #169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pubsub.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ module.exports = (common) => {
expect(msg.data.toString()).to.equal('hi')
expect(msg).to.have.property('seqno')
expect(Buffer.isBuffer(msg.seqno)).to.be.eql(true)
expect(msg).to.have.property('topicCIDs').eql([topic])
expect(msg).to.have.property('topicIDs').eql([topic])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means that js-ipfs-api is also incorrect. Mind checking that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, already fixed in ipfs-inactive/js-ipfs-http-client#627

expect(msg).to.have.property('from', ipfs1.peerId.id)

ipfs1.pubsub.unsubscribe(topic, handler)
Expand Down