This repository was archived by the owner on Mar 10, 2020. It is now read-only.
chore: re-enable linting #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the JS code was moved into the js/ directory the aegir linting task was no longer considering them for linting. This is because the default globs do not include this path. This PR adds custom lint globs to the aegir config and fixes linting errors. depends on ipfs/aegir#240 License: MIT Signed-off-by: Alan Shaw <[email protected]>
ghost
assigned 
travisperson
approved these changes
Jul 5, 2018
|
I picked off most of them when I did the modularization PR 😉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the JS code was moved into the js/ directory the aegir linting task was no longer considering them for linting. This is because the default globs do not include this path.
This PR adds custom lint globs to the aegir config and fixes linting errors.
depends on ipfs/aegir#240
License: MIT
Signed-off-by: Alan Shaw [email protected]