This repository was archived by the owner on Mar 10, 2020. It is now read-only.
Files add interface #288
Merged
Files add interface #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
force-pushed
the
files-add-interface
branch
from
ce91c3a to
6207ad4
Compare
4 tasks
| if (err) { | ||
| return done(err) | ||
| } | ||
| async.map(res, function map (entry, next) { |
There was a problem hiding this comment.
please try to avoid adding async
There was a problem hiding this comment.
roger. Due to time constraints, can we make that a issue to hit later? It would be good to explain in one paragraph (or even one line -> "async is a huge dependency, makes our browser lib fat") so that @noffle and other contribs try to avoid it in the future?
There was a problem hiding this comment.
sure there is already an issue on js-ipfs for exactly that
| next(null, obj) | ||
| }) | ||
| }, function (err, res) { | ||
| done(err, res) |
There was a problem hiding this comment.
this could have been just passed done directly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #281