Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

Fix cat stream bug #320

Closed
wants to merge 2 commits into from
Closed

Fix cat stream bug #320

wants to merge 2 commits into from

Conversation

ColeMorton
Copy link

@ColeMorton ColeMorton commented Jul 18, 2016

@dignifiedquire Using your snippet from: #55.

ipfs.cat('some hash', function (err, stream) {
  var res = ''

  stream.on('data', function (chunk) {
    res += chunk.toString()
  })

  stream.on('error', function (err) {
    console.error('Oh nooo', err)    
  })

  stream.on('end', function () {
    console.log('Got:', res)
  })
})

@dignifiedquire
Copy link
Contributor

Thank you, sorry for the delayed answer. Could you please make sure that linting passes on the code, other than that it looks good :)

@daviddias
Copy link
Contributor

This will also require a rebase from master onto this branch.

@daviddias
Copy link
Contributor

@ColeMorton ping :) Can you get linting to pass and master rebased onto this branch for the merge? thank you

@daviddias
Copy link
Contributor

ping @ColeMorton :)

@dignifiedquire
Copy link
Contributor

This is now fixed in master. Please checkout the example and let us know if it works for you know.

@daviddias
Copy link
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants