Add webpack example #421
Add webpack example #421
Conversation
| "browser": true, | ||
| "esnext": true, | ||
| "newcap": false | ||
| } |
There was a problem hiding this comment.
do we really need jshint and eslint?
| @@ -0,0 +1,42 @@ | |||
| { | |||
| "name": "react-hot-boilerplate", | |||
There was a problem hiding this comment.
lets rename this properly
| { | ||
| "name": "react-hot-boilerplate", | ||
| "version": "1.0.0", | ||
| "description": "Boilerplate for ReactJS project with hot code reloading", |
There was a problem hiding this comment.
can update this as well
| "edit", | ||
| "webpack" | ||
| ], | ||
| "author": "Dan Abramov <[email protected]> (http://github.com/gaearon)", |
There was a problem hiding this comment.
I don't think Dan wrote this ;)
| import ipfsAPI from 'ipfs-api' | ||
|
|
||
| var ipfs = ipfsAPI('localhost', '5001') | ||
| const stringToUse = 'Hello World From Webpack' |
There was a problem hiding this comment.
lets make it hello world from wepbacked IPFS
| }) | ||
| ipfs.dht.findprovs(hash, (err, res) => { | ||
| if (err) throw err | ||
| console.log('found provs!') |
There was a problem hiding this comment.
why not write this to the dom like the others do?
|
@dignifiedquire thanks for the review. The example comes from a quick setup I did, coming from Dan's react hot boilerplate. I'll address the things you've mentioned, and also remove the findprovs part (since it's out of scope of the example). Thanks! |
|
Sweeeet! :D Can we call the folder Also, can you add a README just explaining what people are doing with all of this pieces? Or even just say? "Copy this to your workspace and you get it working by running X Y Z commands" |
|
@diasdavid you got it! 👍 |
|
awesome. Also update the readme section https://github.com/ipfs/js-ipfs-api#in-a-web-browser-through-browserify to point to both examples :) |
victorb
force-pushed
the
add-webpack-example
branch
2 times, most recently
from
90fe45b to
397c816
Compare
|
Thanks for the feedback, everything have been addressed now! @diasdavid @dignifiedquire please take a look again and merge if 👍 |
victorb
force-pushed
the
add-webpack-example
branch
3 times, most recently
from
0a729c2 to
2cea58b
Compare
victorb
force-pushed
the
add-webpack-example
branch
from
2cea58b to
dc30de9
Compare
|
@diasdavid linting should pass now, yes. |
daviddias
added this to the q4j - Quick Start examples for js-ipfs and js-ipfs-api milestone
Comes from https://github.com/VictorBjelkholm/webpack-node-ipfs-api-demo which I'll deprecate if we decide to merge this.