This repository was archived by the owner on Mar 10, 2020. It is now read-only.
feat: upgrade to awesome dag-pb #444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
force-pushed
the
feat/awesome-dag-pb
branch
from
759a3a7 to
b7ddcbc
Compare
haadcode
reviewed
Nov 24, 2016
| if (err) { | ||
| return callback(err) | ||
| } | ||
|
|
||
| if (nodeJSON.Hash !== result.Hash) { | ||
| return callback(new Error('Stored object was different from constructed object')) | ||
| if (node.toJSON.multihash !== result.Hash) { |
There was a problem hiding this comment.
Should be: node.toJSON().multihash
|
One bug, otherwise LGTM. |
daviddias
force-pushed
the
feat/awesome-dag-pb
branch
from
b7ddcbc to
1e82b8c
Compare
|
Thank you for reviewing @haadcode :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs: