Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

chore: use tildes for pre-v1 deps #773

Merged
merged 1 commit into from
May 22, 2018
Merged

Conversation

achingbrain
Copy link
Collaborator

Our rule is: Use ~ for everything below 1.0.0 and ^ for everything above 1.0.0. If you find a package.json that is not following this rule, please submit a PR.

https://github.com/ipfs/community/blob/master/js-code-guidelines.md#dependency-versions

@achingbrain achingbrain requested review from alanshaw and daviddias May 21, 2018 15:30
@ghost ghost assigned achingbrain May 21, 2018
@ghost ghost added the in progress label May 21, 2018
Copy link
Contributor

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alanshaw alanshaw merged commit 7ee17ba into master May 22, 2018
@alanshaw alanshaw deleted the use-tildes-for-pre-v1-deps branch May 22, 2018 09:49
@ghost ghost removed the in progress label May 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants