This repository was archived by the owner on Mar 10, 2020. It is now read-only.
fix: configure webpack to not use esmodules in dependencies #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Big.js just released an update that added esmodule support by adding a "module" field to their package.json. By default, webpack will use this field when requiring a module. Since esmodules aren't fully supported in the browser and we don't do any transpiling this PR configures webpack to not consider the esmodule field. [Webpack `mainFields` docs](https://webpack.js.org/configuration/resolve/#resolve-mainfields) [Why `require('big.js')` is broken for us](webpack/webpack#4742) Refs ipfs/js-ipfs#1363 Note that this solves the issue for `big.js`, but also for any other modules in the future that decide to define a `module` field in their `package.json` or any that already do and we just haven't realised it yet! License: MIT Signed-off-by: Alan Shaw <[email protected]>
ghost
assigned 
daviddias
approved these changes
May 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big.js just released an update that added esmodule support by adding a "module" field to their package.json. By default, webpack will use this field when requiring a module. Since esmodules aren't fully supported in the browser and we don't do any transpiling this PR configures webpack to not consider the esmodule field.
Webpack
mainFieldsdocsWhy
require('big.js')is broken for usRefs ipfs/js-ipfs#1363
Note that this solves the issue for
big.js, but also for any other modules in the future that decide to define amodulefield in theirpackage.jsonor any that already do and we just haven't realised it yet!