Skip to content
This repository was archived by the owner on Apr 29, 2020. It is now read-only.

pull #17

Merged
merged 1 commit into from
Sep 7, 2016
Merged

pull #17

merged 1 commit into from
Sep 7, 2016

Conversation

daviddias
Copy link
Collaborator

@daviddias daviddias commented Sep 2, 2016

@dignifiedquire can you try the examples/echo?

@dignifiedquire
Copy link
Contributor

  • Example is working
  • Tests are working except one, but not sure where the failure is coming from:
libp2p-ipfs crash that node, make sure nodeA continues going steady:
     Uncaught AssertionError: expected [ Array(4) ] to have a length of 3 but got 4
      at Timeout.check [as _onTimeout] (test/libp2p.spec.js:413:42)

@daviddias
Copy link
Collaborator Author

Seems that the cleanup is not done properly, because errors are not being propagate as they should.

@dignifiedquire
Copy link
Contributor

Seems that the cleanup is not done properly, because errors are not being propagate as they should.

I figured out why it's not closing, in the stream -> pull-stream -> stream conversion between tcp and spdy the close event gets lost, and only end is emitted to spdy, resulting in spdy not properly closing things. I have a hack to fix it, but need to investigate more to find a good fix.

@dignifiedquire
Copy link
Contributor

@diasdavid fixed with this: libp2p/js-libp2p-spdy@be7f084

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants