-
Notifications
You must be signed in to change notification settings - Fork 40
feat: script to compare fresh install time #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
olizilla
wants to merge
6
commits into
master
Choose a base branch
from
docker-perf-test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f7ff062
feat: script to compare fresh install time
olizilla 174eda2
chore: fix comment. more named variables
olizilla 44b3348
Update test/perf/docker-race.sh
olizilla 3184780
fix: rm containers after use
olizilla b2f58a5
fix: rm containers after use
olizilla 6a0d227
fix: fail on error
olizilla File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
node_modules | ||
.git |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,3 +2,5 @@ test | |
dist | ||
img | ||
ci | ||
.dockerignore | ||
Dockerfile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# Build ipfs-npm from src. Used in test/perf/docker-race.sh | ||
FROM node:10.15.3 | ||
MAINTAINER olizilla <[email protected]> | ||
|
||
WORKDIR /opt/npm-on-ipfs | ||
|
||
# Create a docker cache layer for just the deps. This means less rebuilding if | ||
# only the source code changes | ||
COPY package.json /opt/npm-on-ipfs | ||
RUN npm install --quiet | ||
|
||
# Copy the src dir to the image, and add `ipfs-npm` to the PATH. | ||
COPY ./src /opt/npm-on-ipfs/src | ||
RUN npm link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
#!/usr/bin/env bash | ||
|
||
# Compare the first install times of a module via npm and ipfs-npm. | ||
# Using Docker here to ensure we are using fresh caches for each run. | ||
# | ||
# Usage: | ||
# | ||
# ./docker-race.sh [npm module] | ||
# | ||
# NOTE: On first run this will create a local image called ipfs-npm, from the | ||
# Dockerfile at the root of this project. To update it with the latest source, | ||
# rebuild the image: | ||
# | ||
# docker build -t ipfs-npm . | ||
# | ||
# or simply delete it and let the script re-build it | ||
# | ||
# docker image rm ipfs-npm -f | ||
# | ||
MODULE=${1:-iim} | ||
IPFS_NPM_IMAGE=ipfs-npm | ||
REFERENCE_IMAGE=node:10.15.3 | ||
|
||
if $(docker image ls | grep -q $IPFS_NPM_IMAGE) | ||
then | ||
echo "found ipfs-npm Docker image" | ||
else | ||
echo "building docker image for ipfs-npm, this will take a moment" | ||
docker build -t $IPFS_NPM_IMAGE ../../ | ||
fi | ||
|
||
echo "" | ||
echo "---- ipfs-npm flavour ----" | ||
time docker run $IPFS_NPM_IMAGE ipfs-npm install -g $MODULE | ||
olizilla marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
echo "" | ||
echo "---- npm flavour ----" | ||
time docker run $REFERENCE_IMAGE npm install -g $MODULE | ||
olizilla marked this conversation as resolved.
Show resolved
Hide resolved
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.