Avoid callback hell

[dignifiedquire]

As we are using callbacks in quite a lot of places and probably will so for a long time I would like to suggest adding these two new rules to the eslint config to enforce any deep nesting

• http://eslint.org/docs/rules/max-nested-callbacks max: 3
• http://eslint.org/docs/rules/max-depth max: 4

[dignifiedquire]

cc @diasdavid @noffle @nginnever @RichardLitt

[daviddias]

This one could be just part of the CR process. Make sure it is always easy to read.

[RichardLitt]

I think that enforcing max-depth makes sense. Refactoring is easier. Adding it to the ESLint and then having a note about why in the js-contributing.md sounds good to me. Shall I?

[dignifiedquire]

Make sure it is always easy to read.

CR failed so far catching this consistently if I look at some parts of the js-ipfs-* code base, so while that should be a goal I feel we should enforce it using the linter.

Adding it to the ESLint and then having a note about why in the js-contributing.md sounds good to me. Shall I?

If everyone is happy, yes please :)

[daviddias]

What if we make the max being 4, because you know, with 2 spaces tabs, that is just 8 spaces total, not that bad :D

[dignifiedquire]

@diasdavid 4 sounds 👍 to me

[daviddias]

let's do it :)

[RichardLitt]

Ahhh Ok! Thanks @dignifiedquire