make sure npm start runs ./build.sh
#18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise assets will not build correctly. Maybe there should be a check somewhere, as it took me a while to figure out what was wrong
|
cc @krl |
jbenet
added a commit
that referenced
this pull request
Jun 29, 2015
make sure `npm start` runs `./build.sh`
hacdias
added a commit
that referenced
this pull request
Aug 29, 2019
# This is the 1st commit message: try gh actions License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #2: add build License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #3: License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #4: License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #5: add gh token License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #6: fix names License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #7: add chrome-log driver License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #8: License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #9: xvfb? License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #10: install xvfb License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #11: License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #12: License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #13: License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #14: add screensize License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #15: License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #16: License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #17: xvfb-maybe License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #18: chore! License: MIT Signed-off-by: Henrique Dias <[email protected]>
hacdias
added a commit
that referenced
this pull request
Sep 2, 2019
# This is the 1st commit message: try gh actions License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #2: add build License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #3: License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #4: License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #5: add gh token License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #6: fix names License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #7: add chrome-log driver License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #8: License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #9: xvfb? License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #10: install xvfb License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #11: License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #12: License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #13: License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #14: add screensize License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #15: License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #16: License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #17: xvfb-maybe License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #18: chore! License: MIT Signed-off-by: Henrique Dias <[email protected]>
hacdias
added a commit
that referenced
this pull request
Sep 2, 2019
# This is the 1st commit message: try gh actions License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #2: add build License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #3: License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #4: License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #5: add gh token License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #6: fix names License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #7: add chrome-log driver License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #8: License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #9: xvfb? License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #10: install xvfb License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #11: License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #12: License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #13: License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #14: add screensize License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #15: License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #16: License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #17: xvfb-maybe License: MIT Signed-off-by: Henrique Dias <[email protected]> # This is the commit message #18: chore! License: MIT Signed-off-by: Henrique Dias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise assets will not build correctly. Maybe there should be
a check somewhere, as it took me a while to figure out what was wrong