-
Notifications
You must be signed in to change notification settings - Fork 430
fix links #1306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix links #1306
Conversation
(I'll keep editing this comment as I have further questions) @TMoMoreau Commenting here about links I'm unsure of: ipfs-docs/docs/concepts/further-reading/academic-papers.md
Random notes about other pages:
/ipfs-docs/docs/concepts/case-study-audius.md
/ipfs-docs/docs/concepts/case-study-likecoin.md
/projects/ipfs-docs/docs/concepts/case-study-snapshot.md
/projects/ipfs-docs/docs/how-to/browser-tools-frameworks.md
/projects/ipfs-docs/docs/how-to/create-simple-chat-app.md
/projects/ipfs-docs/docs/project/history.md
|
@DannyS03 can you take a look at the links to the LibP2P docs from Also, in The commit diff should have context 398b050 Also, can you look at 0faae21#r997293840 and LMK if you have thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/project/.swp
seems like detritus
|
The missing redirect here will also be applied in the restructure PR. We had combined /tutorials/ and /examples/ under /tutorials/ -> https://docs.libp2p.io/tutorials/ |
@johndmulhausen it spilled over from some python stuff I was working on, deleted from the project |
This looks mostly good to me, there are a few changes in here that aren't strictly link fixes, which should be fine so long as the changes are accurate. There are also some libp2p link changes in here that @DannyS03 has requested be changed or left the way they were, I think it would be best to make those changes first, then we should be good to go here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that the Doks theme is merged, we can update these links to be up-to-date instead of relying on redirects.
Hey @DannyS03, I updated the links 7f54aa2. However, markdown-link-check is showing 3 other busted links. Was wondering if it might have to do with the updated site.
|
Hey @ElPaisano, nice. For some of the redirects, strange as we have included them in the aliases.
|
Updated in 88eea40. Link checker came back clean. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @ElPaisano!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
This pr fixes various broken or incorrectly formatted links in the ipfs-docs repo.
The markdown-link-check tool was run against each .md file in the repo and any bad links were fixed.