-
Notifications
You must be signed in to change notification settings - Fork 430
feat: content status with related resources #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM 😍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool thx @cwaring!
A couple quick suggestions. Some are global styles, so we can likely address later.
- Go ahead and bump "Is this important" up to an
h3
, mea culpa - Reduce the spacing below the headings, for better vertical rhythm (see image for rough idea)
- Make button labels bold
- Remove the icon that's after the camp link
- Unlink "Help us improve this page on" so that only "GitHub" is a link
- Make this ^ "GitHub" link the link color
Thanks @ericronne, I agree but ideally tweaks 2-6 should not be not part of this PR because we need to setup global styles for them to retain consistency and easy of maintenance - otherwise the app will soon get littered with unique pixel values. I would suggest that we address it in the CSS edits branch so it can be become an inherited style. I'll apply a quick patch in this branch for a visual ref so we can migrate it across later, including the button style etc :) |
Yes i suspected as much. ✊ |
This PR implements ipfs-inactive/docs#342.
It registers a new global component that can be used in any markdown file, simply add the following line:
You can also use front matter data to configure the display and add related items.
The interaction logic for the voting mechanism will come in a later PR.