Skip to content

feat: content status with related resources #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 3, 2019
Merged

Conversation

cwaring
Copy link
Member

@cwaring cwaring commented Dec 3, 2019

This PR implements ipfs-inactive/docs#342.

It registers a new global component that can be used in any markdown file, simply add the following line:

<ContentStatus title="**optional**" />

You can also use front matter data to configure the display and add related items.

issueNum: 333 # used to connect to the related issue for the content
related: # nested key, value items rendered as links
  an interesting article: https://ipfs.io
  another interesting article: https://ipfs.io

cs-dt
cs-mb

The interaction logic for the voting mechanism will come in a later PR.

@jessicaschilling
Copy link
Contributor

LGTM 😍

Copy link

@ericronne ericronne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thx @cwaring!

A couple quick suggestions. Some are global styles, so we can likely address later.

  1. Go ahead and bump "Is this important" up to an h3, mea culpa
  2. Reduce the spacing below the headings, for better vertical rhythm (see image for rough idea)
  3. Make button labels bold
  4. Remove the icon that's after the camp link
  5. Unlink "Help us improve this page on" so that only "GitHub" is a link
  6. Make this ^ "GitHub" link the link color
    image

@cwaring
Copy link
Member Author

cwaring commented Dec 3, 2019

Thanks @ericronne, I agree but ideally tweaks 2-6 should not be not part of this PR because we need to setup global styles for them to retain consistency and easy of maintenance - otherwise the app will soon get littered with unique pixel values. I would suggest that we address it in the CSS edits branch so it can be become an inherited style.

I'll apply a quick patch in this branch for a visual ref so we can migrate it across later, including the button style etc :)

@ericronne
Copy link

Yes i suspected as much. ✊

@cwaring cwaring merged commit 02d2432 into master Dec 3, 2019
@cwaring cwaring deleted the feat/content-status branch December 3, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants