-
Notifications
You must be signed in to change notification settings - Fork 430
feat: metrics widget & unified page footer #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On beta, adds callout for feedback/beta signup/equivalent legacy pages
This was referenced Dec 12, 2019
jessicaschilling
approved these changes
Dec 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IT'S GLORIOUS YES I AM SHOUTING
PUT IT ON A GLORIOUS BOAT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the following issues:
ipfs-inactive/docs#306 ipfs-inactive/docs#407 ipfs-inactive/docs#406 ipfs-inactive/docs#342 ipfs-inactive/docs#341
New components:
<EditOrIssue />
<Feedback />
Associated config props:
<LegacyCallout />
Default events for metrics widget:
information_helpful
information_not_helpful
topic_important
topic_not_important
New Page template to tie all the layout together.
Associated views:
Test url: https://deploy-preview-41--ipfs-docs-v2.netlify.com/
Draft PR. Changelog TBC
closes: ipfs-inactive/docs#306 ipfs-inactive/docs#407 ipfs-inactive/docs#406 ipfs-inactive/docs#342 ipfs-inactive/docs#341
Page footer to do …
Widget