Skip to content

feat: metrics widget & unified page footer #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 42 commits into from
Dec 13, 2019
Merged

Conversation

cwaring
Copy link
Member

@cwaring cwaring commented Dec 10, 2019

This PR resolves the following issues:
ipfs-inactive/docs#306 ipfs-inactive/docs#407 ipfs-inactive/docs#406 ipfs-inactive/docs#342 ipfs-inactive/docs#341

New components:

<EditOrIssue />

<Feedback />

Associated config props:

  props: {
    titleTxt: {
      type: String,
      default: 'Was this information helpful?'
    },
    thanksTxt: {
      type: String,
      default: 'Thank you for the feedback.'
    },
    evtYes: {
      type: String,
      default: 'yes'
    },
    evtNo: {
      type: String,
      default: 'no'
    },
    yesTxt: {
      type: String,
      default: 'Yes'
    },
    noTxt: {
      type: String,
      default: 'No'
    },
    editOrIssueLinks: {
      type: Boolean,
      default: true
    }
  }

<LegacyCallout />

Default events for metrics widget:
information_helpful
information_not_helpful
topic_important
topic_not_important

New Page template to tie all the layout together.

Associated views:

CleanShot 2019-12-12 at 18 27 44
CleanShot 2019-12-12 at 18 27 14
CleanShot 2019-12-12 at 18 26 49

Test url: https://deploy-preview-41--ipfs-docs-v2.netlify.com/

Draft PR. Changelog TBC
closes: ipfs-inactive/docs#306 ipfs-inactive/docs#407 ipfs-inactive/docs#406 ipfs-inactive/docs#342 ipfs-inactive/docs#341

Page footer to do …

  • Add vertical spacing above the callout (should match spacing between major page sections)
  • Split the four links into two columns on desktop
  • Change the "View this page on legacy site" to regular (thinner) weight font

Widget

  • Edit this page or open an issue
  • Add GA custom events
  • Add props for template strings and events
  • Setup widget on Content Status view
  • Check events are tracking

@cwaring cwaring changed the title feat: helpful widget & unified page footer feat: metrics widget & unified page footer Dec 10, 2019
@cwaring cwaring marked this pull request as ready for review December 12, 2019 18:37
Copy link
Contributor

@jessicaschilling jessicaschilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IT'S GLORIOUS YES I AM SHOUTING
PUT IT ON A GLORIOUS BOAT

@cwaring cwaring merged commit aa393ee into master Dec 13, 2019
@cwaring cwaring deleted the feat/metrics-widget branch December 13, 2019 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement "is this helpful" widget
2 participants