Skip to content

Fix inconsistencies discovered in #261 #303

Description

@Gozala
  1. Should be timeout instead (as per comment here https://github.com/ipfs/js-ipfs-bitswap/pull/261/files#r589357353)

    // TODO: Should this be a timeout options insetad ?
    // @ts-expect-error - 'maxTimeout' does not exist in type
    maxTimeout: CONSTANTS.providerRequestTimeout,

  2. equality check on messages seems to have a bug (for more context see https://github.com/ipfs/js-ipfs-bitswap/pull/261/files#r587863878)

    // @TODO - Is this a bug ?
    // @ts-expect-error - isMap equals map values to be objects not numbers
    !isMapEqual(this.blockPresences, other.blockPresences)

  3. Want list entries sorting has a bug (See https://github.com/ipfs/js-ipfs-bitswap/pull/261/files#r587867673)

  4. Need to specify want type when adding it to wantlist (see https://github.com/ipfs/js-ipfs-bitswap/pull/261/files#r587865473)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions