Make consistent with go #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
ipfs-inactive/js-ipfs-unixfs-engine#213 should be merged along with this PR. |
This was referenced May 29, 2018
|
yay... bug for bug compatibility |
|
@diasdavid @alanshaw Any objections to merging this? |
|
@achingbrain are there interop tests so that this doesn't bite us again? |
|
@diasdavid I'm adding a whole bunch to the ipfs/interop repo. |
|
These |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go:
$ touch emptyfile $ ipfs add emptyfile added QmbFMke1KXqnYyBBWxB74N4c5SBnJMVAiMNRcGu6x1AwQH emptyfile $ ipfs object data QmbFMke1KXqnYyBBWxB74N4c5SBnJMVAiMNRcGu6x1AwQH | xxd 00000000: 0802 1800Without this PR:
$ jsipfs add emptyfile added QmfJMCvenrj4SKKRc48DYPxwVdS44qCUCqqtbqhJuSTWXP emptyfile $ jsipfs object data QmfJMCvenrj4SKKRc48DYPxwVdS44qCUCqqtbqhJuSTWXP | xxd 00000000: 0802 1200 ....With this PR:
$ jsipfs add emptyfile added QmbFMke1KXqnYyBBWxB74N4c5SBnJMVAiMNRcGu6x1AwQH emptyfile $ jsipfs object data QmbFMke1KXqnYyBBWxB74N4c5SBnJMVAiMNRcGu6x1AwQH | xxd 00000000: 0802 1800