Skip to content

fix: write after end #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: write after end #1

wants to merge 1 commit into from

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Jul 2, 2019

Missing return

fix: write after end
e60aee3 
Missing return
@alanshaw
Copy link
Member Author

alanshaw commented Jul 2, 2019

Don't know why electron is fail 😢

@achingbrain
Copy link
Member

Rebasing this after #2 is merged should make electron happy.

@achingbrain
Copy link
Member

Have split the build fix out into #3 so this can be merged independently of #2.

@hugomrdias
Copy link
Member

I merged the electron fix

@alanshaw alanshaw mentioned this pull request Sep 1, 2019
Merged
@alanshaw alanshaw closed this Sep 1, 2019
@alanshaw alanshaw deleted the patch-1 branch September 1, 2019 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugomrdias hugomrdias hugomrdias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanshaw @achingbrain @hugomrdias