-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add document for running JS IPFS in the browser #2392
Conversation
Thanks @tapaswenipathak I'll get round to reviewing this asap! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tapaswenipathak this is a very cool draft! It does pack a few things that are incoherent. I left a few comments :)
@daviddias: you can review now. |
Co-Authored-By: David Dias <[email protected]>
Co-Authored-By: David Dias <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tapaswenipathak! I suggested some changes to make it more aligned with how things look like on the technical side:
Co-Authored-By: Marcin Rataj <[email protected]>
Co-Authored-By: Marcin Rataj <[email protected]>
Co-Authored-By: Marcin Rataj <[email protected]>
Co-Authored-By: Marcin Rataj <[email protected]>
Co-Authored-By: Marcin Rataj <[email protected]>
@lidel: Very creative statements/writeups; you can review now. |
Reorganized the content a bit and added references.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @tapaswenipathak!
I changed the order of the document a bit, and added references to external resources with more info to make this reusable on our docs portal as well (at some point we will move this content to https://docs.ipfs.io/reference/js/overview/, but for now let's keep it here)
LGTM, but I would like someone else to proof-read it before we merge.
This is a great document! It answers many questions in a concise way. Any reason to not merge this as it is, and continue to iterate from there? |
Fixes #2231.