This repository was archived by the owner on Feb 12, 2024. It is now read-only.
Add ipfs config edit to cli #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/cli/commands/config/edit.js
Outdated
| node.version((err, version) => { | ||
| if (err) { return log.error(err) } | ||
| const node = new IPFS() | ||
| const editor = process.env.EDITOR || 'vi' |
Member
There was a problem hiding this comment.
if no editor is defined, just say that no editor is defined (same as go-ipfs)
Member
Author
There was a problem hiding this comment.
yeah I know, this seemed like a better UX to me though. I'll change it :)
fbaiodias
force-pushed
the
feature/config-edit
branch
from
263a70d to
d14df9b
Compare
This was referenced Apr 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #49
Not sure how to test this though, ideas are welcome :)