Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

chore: update deps #978

Merged
merged 6 commits into from
Sep 2, 2017
Merged

chore: update deps #978

merged 6 commits into from
Sep 2, 2017

Conversation

daviddias
Copy link
Member

No description provided.

@daviddias
Copy link
Member Author

I'm seeing multiple errors when js-ipfs-api is being used:

  1) HTTP API ## interface tests .files callback API .add add a nested dir as array:
     Uncaught AssertionError: expected [Error: [object Object]] to not exist
      at ipfs.files.add (node_modules/interface-ipfs-core/src/files.js:154:32)
      at send (node_modules/ipfs-api/src/utils/request-api.js:198:16)
      at f (node_modules/once/once.js:25:25)
      at streamToJsonValue (node_modules/ipfs-api/src/utils/request-api.js:27:5)
      at streamToValue (node_modules/ipfs-api/src/utils/stream-to-json-value.js:30:5)
      at concat (node_modules/ipfs-api/src/utils/stream-to-value.js:12:22)
      at ConcatStream.<anonymous> (node_modules/concat-stream/index.js:36:43)
      at finishMaybe (node_modules/readable-stream/lib/_stream_writable.js:607:14)
      at afterWrite (node_modules/readable-stream/lib/_stream_writable.js:470:3)
      at _combinedTickCallback (internal/process/next_tick.js:144:20)
      at process._tickDomainCallback (internal/process/next_tick.js:218:9)

  2) HTTP API ## interface tests .files callback API .add .createAddStream stream of valid files and dirs:
     Uncaught Error: [object Object]
      at parseError (node_modules/ipfs-api/src/utils/request-api.js:17:17)
      at ClientRequest.<anonymous> (node_modules/ipfs-api/src/utils/request-api.js:39:14)
      at HTTPParser.parserOnIncomingClient (_http_client.js:565:21)
      at HTTPParser.parserOnHeadersComplete (_http_common.js:116:23)
      at Socket.socketOnData (_http_client.js:454:20)
      at addChunk (_stream_readable.js:266:12)
      at readableAddChunk (_stream_readable.js:253:11)
      at Socket.Readable.push (_stream_readable.js:211:10)
      at TCP.onread (net.js:585:20)

  3) HTTP API ## interface tests .files callback API .cat with ipfs path, nested value:
     Error: Timeout of 80000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.


  4) HTTP API ## interface tests .files callback API .get directory:
     Error: Timeout of 80000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.


  5) HTTP API ## interface tests .files callback API .get with ipfs path, nested value:
     Uncaught AssertionError: expected [Error: socket hang up] to not exist
      at ipfs.files.get (node_modules/interface-ipfs-core/src/files.js:373:32)
      at send (node_modules/ipfs-api/src/utils/request-api.js:198:16)
      at f (node_modules/once/once.js:25:25)
      at ClientRequest.req.on (node_modules/ipfs-api/src/utils/request-api.js:158:5)
      at Socket.socketOnEnd (_http_client.js:437:9)
      at endReadableNT (_stream_readable.js:1059:12)
      at _combinedTickCallback (internal/process/next_tick.js:138:11)
      at process._tickDomainCallback (internal/process/next_tick.js:218:9)

  6) cli files daemon on (through http-api) add recursively test:
     Command failed: /Users/imp/code/js-ipfs/src/cli/bin.js files add -r test/test-data/recursive-get-dir
/Users/imp/code/js-ipfs/src/cli/commands/files/add.js:69
        throw err
        ^

Error: [object Object]
    at parseError (/Users/imp/code/js-ipfs/node_modules/ipfs-api/src/utils/request-api.js:17:17)
    at ClientRequest.<anonymous> (/Users/imp/code/js-ipfs/node_modules/ipfs-api/src/utils/request-api.js:39:14)
    at Object.onceWrapper (events.js:316:30)
    at emitOne (events.js:115:13)
    at ClientRequest.emit (events.js:210:7)
    at HTTPParser.parserOnIncomingClient (_http_client.js:565:21)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:116:23)
    at Socket.socketOnData (_http_client.js:454:20)
    at emitOne (events.js:115:13)
    at Socket.emit (events.js:210:7)


  Error: Command failed: /Users/imp/code/js-ipfs/src/cli/bin.js files add -r test/test-data/recursive-get-dir
  /Users/imp/code/js-ipfs/src/cli/commands/files/add.js:69
          throw err
          ^

  Error: [object Object]
      at parseError (node_modules/ipfs-api/src/utils/request-api.js:17:17)
      at ClientRequest.<anonymous> (node_modules/ipfs-api/src/utils/request-api.js:39:14)
      at HTTPParser.parserOnIncomingClient (_http_client.js:565:21)
      at HTTPParser.parserOnHeadersComplete (_http_common.js:116:23)
      at Socket.socketOnData (_http_client.js:454:20)


      at Promise.all.then.arr (node_modules/execa/index.js:236:11)
      at <anonymous>
      at process._tickDomainCallback (internal/process/next_tick.js:228:7)

  7) cli files daemon on (through http-api) add and wrap with a directory:

      AssertionError: expected 'added QmPZ9gcCEpqKTo6aq61g2nXGUhM4iCL3ewB6LDXZCtioEB 2Freadme\n' to deeply equal 'added QmPZ9gcCEpqKTo6aq61g2nXGUhM4iCL3ewB6LDXZCtioEB readme\nadded QmapdaVPjHXdcswef82FnGQUauMNpk9xYFkLDZKgAxhMwq\n'
      + expected - actual

      -added QmPZ9gcCEpqKTo6aq61g2nXGUhM4iCL3ewB6LDXZCtioEB 2Freadme
      +added QmPZ9gcCEpqKTo6aq61g2nXGUhM4iCL3ewB6LDXZCtioEB readme
      +added QmapdaVPjHXdcswef82FnGQUauMNpk9xYFkLDZKgAxhMwq

      at ipfs.then (test/cli/files.js:132:25)
      at <anonymous>
      at process._tickDomainCallback (internal/process/next_tick.js:228:7)

  8) cli files daemon on (through http-api) get recursively:
     Error: Command failed: /Users/imp/code/js-ipfs/src/cli/bin.js files get QmYmW4HiZhotsoSqnv2o1oUusvkRM8b9RweBoH7ao5nki2


      at Promise.all.then.arr (node_modules/execa/index.js:236:11)
      at <anonymous>
      at process._tickDomainCallback (internal/process/next_tick.js:228:7)

Investigating..

@daviddias
Copy link
Member Author

Ok, regression was caused by ipfs-inactive/js-ipfs-http-client@717c72f, now figuring out why.

@daviddias
Copy link
Member Author

daviddias commented Sep 2, 2017

Correction, it was actually the encodeURIComponent on ipfs-inactive/js-ipfs-http-client@322b756

It was not checking for when we don't passa fileName properly.

@daviddias
Copy link
Member Author

@daviddias daviddias merged commit 7544b7b into master Sep 2, 2017
@daviddias daviddias deleted the update-deps branch September 2, 2017 22:32
MicrowaveDev pushed a commit to galtproject/js-ipfs that referenced this pull request May 22, 2020
BREAKING CHANGE: ipfs.refs now returns objects with camelCase properties not PascalCase properties. i.e. `{ ref, err }` not `{ Ref, Err }`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants