-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat: AutoTLS with AutoNATv2 client #10835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sukunrt, fixed CI and took this for a spin and it seems to work as expected.
Two asks:
- One CI test failure remains:
TestDHTConnectivityFast
from./test/integration/wan_lan_dht_test.go
started failing- I've re-run it and it fails every time. I'm not familiar with it, it was introduced in 2020 before my time in go-ipfs (#7151). Mind taking a look?
- Is this PR effectively disabling AutoNAT v1 client or is go-libp2p node running both? p2p-forge/client seems to support both, which is good for transition period, but unclear if both events are emitted by
go-libp2p v0.42.0-alpha
- Should we update docs at https://github.com/ipfs/kubo/blob/master/docs/config.md#autonatservicemode and code in
./core/node/libp2p/nat.go
to removelegacy-v1
andAutoNATServiceEnabledV1Only
, or ok to keep for one more release?- tldr: we have both for now, so keeping as-is
- Should we update docs at https://github.com/ipfs/kubo/blob/master/docs/config.md#autonatservicemode and code in
go-libp2p v0.42 supports both and depends on both. Autorelay still uses autonatv1. So kubo can remove autonatv1 from go-libp2p v0.43 onwards. |
12684e9
to
e295cdb
Compare
This is a mocknet bug. The new addrs manager depends on the new listen addrs event from the swarm. Fixed mocknet to send this event and to use |
55ac0c7
to
7eeda03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sukunrt!
I've switched this PR to commit from main branch at https://github.com/ipshipyard/p2p-forge with your fix.
On top of green CI, I did basic manual regression/smoke-tests and AutoTLS works as expected for IPv4, I'm going to merge this so we can include it in RC1.
Once we have final go-libp2p 0.42, we can bump go.mod
before final Kubo 0.36.
This updates libp2p and autotls to test changes autonatv2 changes. Post this we'd not need to have a large registration delay.
The corresponding autotls change is here: