Skip to content

Add readonly api to gateway #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2015
Merged

Conversation

rht
Copy link
Contributor

@rht rht commented Aug 15, 2015

Based on #1389

(wip)

@jbenet jbenet added the status/in-progress In progress label Aug 15, 2015
@jbenet
Copy link
Member

jbenet commented Aug 15, 2015

cc @harlantwood as he'll be interested to follow this

@rht
Copy link
Contributor Author

rht commented Aug 15, 2015

The remaining todo here is to write test cases. Suggestions?

@harlantwood
Copy link
Contributor

Great to see this moving! We're doing interesting work on the graph visualization side... Will share more soon.

@rht rht force-pushed the feat/read-only-api-gateway branch from 5823cde to 3357d2f Compare August 15, 2015 08:08
@rht
Copy link
Contributor Author

rht commented Aug 15, 2015

@jbenet are the test cases adequate? If so, RFM. Otherwise testing all the API commands might be redundant.

Based on ipfs#1389

License: MIT
Signed-off-by: rht <[email protected]>
@rht rht force-pushed the feat/read-only-api-gateway branch from 3357d2f to dd99a70 Compare August 15, 2015 10:09
@jbenet
Copy link
Member

jbenet commented Aug 15, 2015

@rht looks great to me! so simple :) 👍

jbenet added a commit that referenced this pull request Aug 15, 2015
@jbenet jbenet merged commit fbac820 into ipfs:master Aug 15, 2015
@jbenet jbenet removed the status/in-progress In progress label Aug 15, 2015
@jbenet
Copy link
Member

jbenet commented Aug 15, 2015

@harlantwood @krl read only api is in! 👍 thanks @rht

@harlantwood
Copy link
Contributor

Awesome thanks @rht!

@harlantwood
Copy link
Contributor

@jbenet I'm interested to know when this is released to the public gateway. Is there a way we track what is released there? Otherwise maybe comment here when it's live.

@jbenet
Copy link
Member

jbenet commented Aug 15, 2015

@lgierth could you deploy to public gateways?


Sent from Mailbox

On Sat, Aug 15, 2015 at 6:32 PM, Harlan T Wood [email protected]
wrote:

@jbenet I'm interested to know when this is released to the public gateway. Is there a way we track what is released there? Otherwise maybe comment here when it's live.

Reply to this email directly or view it on GitHub:
#1581 (comment)

@whyrusleeping
Copy link
Member

👍

},
},
"cat": CatCmd,
"commands": CommandsDaemonCmd,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, one more small fix: this lists the Root commands instead of RootRO.

@rht
Copy link
Contributor Author

rht commented Aug 16, 2015

API is sanitized here #1583

@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants