Skip to content

EOF: CREATE3 with alternative header format (CONTAINER_TYPES section)#723

Closed
gumb0 wants to merge 15 commits intomasterfrom
eof-create3-deploy-size-in-header
Closed

EOF: CREATE3 with alternative header format (CONTAINER_TYPES section)#723
gumb0 wants to merge 15 commits intomasterfrom
eof-create3-deploy-size-in-header

Conversation

@gumb0
Copy link
Copy Markdown
Member

@gumb0 gumb0 commented Oct 24, 2023

TODO:

  • Fix EOF1Header::aux_data_size()
  • Validate DATALOADN against container deploy size
  • Validate CREATE3 to not allow truncated containers
  • Fix tests

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 24, 2023

Codecov Report

Merging #723 (3c9e1bf) into master (634d706) will decrease coverage by 70.89%.
Report is 2 commits behind head on master.
The diff coverage is 5.40%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #723       +/-   ##
===========================================
- Coverage   97.70%   26.81%   -70.89%     
===========================================
  Files         101       99        -2     
  Lines        9377     8792      -585     
===========================================
- Hits         9162     2358     -6804     
- Misses        215     6434     +6219     
Flag Coverage Δ
blockchaintests 55.80% <3.40%> (-6.57%) ⬇️
statetests ?
statetests-silkpre 24.57% <5.40%> (-1.57%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/evmone/advanced_instructions.cpp 100.00% <ø> (ø)
lib/evmone/baseline_instruction_table.cpp 100.00% <ø> (ø)
lib/evmone/execution_state.hpp 66.66% <ø> (-29.56%) ⬇️
test/state/state.cpp 74.66% <100.00%> (-25.34%) ⬇️
test/unittests/instructions_test.cpp 0.00% <ø> (-89.59%) ⬇️
test/unittests/eof_test.cpp 0.00% <0.00%> (-94.29%) ⬇️
lib/evmone/eof.hpp 17.64% <0.00%> (-82.36%) ⬇️
test/unittests/state_transition.cpp 0.00% <0.00%> (-94.92%) ⬇️
test/state/host.cpp 88.63% <63.63%> (-4.47%) ⬇️
lib/evmone/baseline.cpp 66.36% <18.75%> (-33.64%) ⬇️
... and 7 more

... and 75 files with indirect coverage changes

@gumb0 gumb0 force-pushed the eof-create3-deploy-size-in-header branch 2 times, most recently from c37918d to 78bcc56 Compare October 24, 2023 19:35
@gumb0 gumb0 force-pushed the eof-create3-deploy-size-in-header branch from e388bb6 to de1b5aa Compare October 25, 2023 10:22
@gumb0 gumb0 force-pushed the eof-create3-deploy-size-in-header branch from de1b5aa to 3c9e1bf Compare October 25, 2023 16:54
@gumb0
Copy link
Copy Markdown
Member Author

gumb0 commented Dec 4, 2023

Closing in favor of approach in #553

@gumb0 gumb0 closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant