update_config only loads *new* config#123
Merged
minrk merged 1 commit intoipython:masterfrom Feb 12, 2016
Merged
Conversation
Member
|
works for me. Do you want to address the todo now? or later ? |
Member
Author
|
No, the TODO should wait for the dict-change events, which don't exist. |
Member
|
This needs a rebase. |
minrk
force-pushed
the
partial-update
branch
from
67a723c to
ef340bc
Compare
Member
Author
|
Rebased |
rather than trigger `_config_changed`, which reloads *all* config, even what's already been loaded.
minrk
force-pushed
the
partial-update
branch
from
ef340bc to
47a46b1
Compare
minrk
added a commit
that referenced
this pull request
Feb 12, 2016
update_config only loads *new* config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rather than trigger
_config_changed, which reloads all config, even what's already been loaded.Should address the repeated warning discussed in #119