Make the JsonFileLoader a context manager#137
Merged
minrk merged 1 commit intoipython:masterfrom Feb 11, 2016
Merged
Conversation
On exit of context manager write file back to disk. That makes it easy to update config.
Member
|
I like it! We can merge once we ship 4.1. |
Member
Author
|
Todo, maybe default the config file to 0x600 |
Member
Author
Ok, I don't know why I wrote that there, it's unrelated to this PR. |
| configuration to disk. | ||
| """ | ||
| with open(self.full_filename, 'w') as f: | ||
| f.write(json.dumps(self.config, indent=2)) |
Member
There was a problem hiding this comment.
If there is an error here, the file will be left empty due to the open(...'w'). Perhaps dump the config prior to opening the file, so that it raises before deleting existing contents.
Member
Author
There was a problem hiding this comment.
Did you take care of that after merging ? Or should I open an issue and do it (sorry I was unavailable to work on that yesterday)
minrk
added a commit
that referenced
this pull request
Feb 11, 2016
Make the JsonFileLoader a context manager
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On exit of context manager write file back to disk.
That makes it easy to update config.