Skip to content

pass *args to __new__ #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
minrk merged 1 commit into from
Feb 17, 2016
Merged

pass *args to __new__ #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions traitlets/traitlets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,14 +898,14 @@ class HasDescriptors(py3compat.with_metaclass(MetaHasDescriptors, object)):
"""The base class for all classes that have descriptors.
"""

def __new__(cls, *args, **kw):
def __new__(cls, *args, **kwargs):
# This is needed because object.__new__ only accepts
# the cls argument.
new_meth = super(HasDescriptors, cls).__new__
if new_meth is object.__new__:
inst = new_meth(cls)
else:
inst = new_meth(cls, **kw)
inst = new_meth(cls, *args, **kwargs)
Copy link
Contributor Author

@rmorshea rmorshea Feb 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a reason *args got left out?

inst.setup_instance()
return inst

Expand Down Expand Up @@ -936,12 +936,12 @@ def setup_instance(self):
self._trait_validators = {}
super(HasTraits, self).setup_instance()

def __init__(self, *args, **kw):
def __init__(self, *args, **kwargs):
# Allow trait values to be set using keyword arguments.
# We need to use setattr for this to trigger validation and
# notifications.
with self.hold_trait_notifications():
for key, value in iteritems(kw):
for key, value in iteritems(kwargs):
setattr(self, key, value)

def __getstate__(self):
Expand Down