Merged
Conversation
In python/cpython#28420 the order of setting the default values on the Namespace object and processing the Actions was reversed. This means that in the `__call__` method of `_FlagAction` the `_flags` attribute has not yet been put on the namespace. This change makes `_FlagAction.__call__` forgiving if the `_flags` attribute does not exist (by creating it!).
tacaswell
force-pushed
the
fix_py310
branch
from
c439c01 to
fe88397
Compare
Member
|
Thanks! |
This was referenced Nov 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In python/cpython#28420 the order of setting the
default values on the Namespace object and processing the Actions was reversed. This means
that in the
__call__method of_FlagActionthe_flagsattribute has notyet been put on the namespace.
This change makes
_FlagAction.__call__forgiving if the_flagsattributedoes not exist (by creating it!).