Skip to content

Use codecov Github action v2#683

Merged
Carreau merged 1 commit intoipython:mainfrom
takluyver:codecov-action-v2
Oct 25, 2021
Merged

Use codecov Github action v2#683
Carreau merged 1 commit intoipython:mainfrom
takluyver:codecov-action-v2

Conversation

@takluyver
Copy link
Member

The v1 action is deprecated due to security concerns, and will stop working in a few months:

https://github.com/marketplace/actions/codecov
https://about.codecov.io/blog/introducing-codecovs-new-uploader/

@takluyver
Copy link
Member Author

I noticed it was trying to upload coverage info after running tests of downstream projects, but those tests weren't collecting coverage data. I've configured the test suites using pytest to collect that information. But this can easily be removed if you prefer not to count coverage from downstream tests. It doesn't appear to make any difference at the moment.

@Carreau Carreau merged commit d2908b7 into ipython:main Oct 25, 2021
@Carreau Carreau added this to the 5.1.1 milestone Oct 25, 2021
@Carreau
Copy link
Member

Carreau commented Oct 25, 2021

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants