fix: mro_trait can be unbound when the class is not in mro#824
Merged
blink1073 merged 1 commit intoipython:mainfrom Jan 8, 2023
Merged
fix: mro_trait can be unbound when the class is not in mro#824blink1073 merged 1 commit intoipython:mainfrom
blink1073 merged 1 commit intoipython:mainfrom
Conversation
Closed
Contributor
|
Unbound locals are apparently tricky to catch with a linter, I found issues on both mypy and pyflakes where they punt on it. |
blink1073
approved these changes
Jan 8, 2023
Contributor
blink1073
left a comment
blink1073
left a comment
There was a problem hiding this comment.
Thanks! I'll release this tomorrow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #823
Not so happy that it doesn't include a test yet, and I think a linter should have picked up this mistake. @blink1073 do you know why CI didn't see this lint issue?