Pass **kwds in MetaHasDescriptors __new__ and __init__#881
Merged
blink1073 merged 1 commit intoipython:mainfrom Oct 21, 2023
fleming79:main
Merged
Pass **kwds in MetaHasDescriptors __new__ and __init__#881blink1073 merged 1 commit intoipython:mainfrom fleming79:main
blink1073 merged 1 commit intoipython:mainfrom
fleming79:main
Conversation
blink1073
approved these changes
Oct 21, 2023
Contributor
blink1073
left a comment
There was a problem hiding this comment.
Sounds reasonable to me, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a modest change that adds
**kwdstoMetaHasDescriptors__new__and__init__to match the signature defined in the Python docs:This enables the usage
__init_subclass__without having to overloadMetaHasDescriptorsto intercept the arguments passed to a subclass.Trivial example
Before
After