Avoid allocating in pre_exec closure#99
Open
purplesyringa wants to merge 1 commit intoironcore-dev:masterfrom
Open
Avoid allocating in pre_exec closure#99purplesyringa wants to merge 1 commit intoironcore-dev:masterfrom
pre_exec closure#99purplesyringa wants to merge 1 commit intoironcore-dev:masterfrom
Conversation
purplesyringa
force-pushed
the
pre-exec
branch
from
9789f9d to
70977fb
Compare
purplesyringa
changed the title
pre_exec closure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error::otherallocates memory (see rust-lang/rust#148971). This is bad in multi-threaded programs, which FeOS AFAIK is. If the fork occurs while the allocator lock is held by another thread, deadlocks can occur, since there's no one left in the new process to unlock the mutex. I do not believe this is UB, and modern libc offer protections against this issue, but this isn't POSIX-compliant and should preferably be avoided.nixprovides a non-allocatingimpl From<Errno> for std::io::Error, which can be used instead. This also ensures that the correct error code is forwarded to the parent process, instead of the default-EINVAL.