-
Notifications
You must be signed in to change notification settings - Fork 5
Drop kube-rbac-proxy
container usage in config
#243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
afritzler
merged 6 commits into
ironcore-dev:main
from
opensovereigncloud:osc/enh/replace-kube-rbac-proxy
Apr 14, 2025
Merged
Drop kube-rbac-proxy
container usage in config
#243
afritzler
merged 6 commits into
ironcore-dev:main
from
opensovereigncloud:osc/enh/replace-kube-rbac-proxy
Apr 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01146ca
to
618a1fc
Compare
…authn/authz for metrics
618a1fc
to
c520545
Compare
c520545
to
9be6bc9
Compare
b2ddaf7
to
75871b8
Compare
e925843
to
e7dea9e
Compare
afritzler
requested changes
Apr 4, 2025
Nuckal777
reviewed
Apr 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. 👍
3d0990a
to
c552e93
Compare
c4b847c
to
9804673
Compare
b3d86d5
to
1620c7d
Compare
1620c7d
to
a6052d1
Compare
Nuckal777
reviewed
Apr 10, 2025
f1ed0ed
to
d020b1e
Compare
Nuckal777
approved these changes
Apr 14, 2025
afritzler
approved these changes
Apr 14, 2025
kube-rbac-proxy
container and adopt controller-runtime native …kube-rbac-proxy
container
kube-rbac-proxy
container kube-rbac-proxy
container usage in config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The PR removes the soon-to-be deprecated
kube-rbac-proxy
container dependency and replaces it withController-Runtime's
built-in authn/authz for securing the metrics endpoint. This simplifies setup, enhances security, and follows the latest Kubebuilder best practices.Key Changes
for ex:
controller-manager and metalprobe docker imagesFixes #209
Ref:
kubernetes-sigs/kubebuilder#3907
kubernetes-sigs/controller-runtime#2407
kubernetes-sigs/kubebuilder#4400
kubernetes-sigs/kubebuilder/docs/reference/metrics (v4.5.0)