Fixes IndexError in reset_joints_by_scale and reset_joints_by_offset #2949
+20
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creampelt
requested review from
jsmith-bdai,
kellyguo11 and
Mayankm96
as code owners
ooctipus
approved these changes
Jul 16, 2025
There was a problem hiding this comment.
@Creampelt Sorry I was my miss!
Thank you for the fix, it looks very good XD
|
This content has not yet been merged into the main branch.. (2025.07.24) |
Signed-off-by: Kelly Guo <[email protected]>
kellyguo11
changed the title
Mayankm96
reviewed
Jul 26, 2025
Mayankm96
reviewed
Jul 26, 2025
Mayankm96
reviewed
Jul 26, 2025
Mayankm96
reviewed
Jul 26, 2025
Mayankm96
reviewed
Jul 26, 2025
Mayankm96
reviewed
Jul 26, 2025
Mayankm96
reviewed
Jul 26, 2025
Mayankm96
reviewed
Jul 26, 2025
Signed-off-by: Emily Sturman <[email protected]>
Add dimension to env_ids (rather than indexing twice) Co-authored-by: Mayank Mittal <[email protected]> Signed-off-by: Emily Sturman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the IndexError caused by simultaneously indexing env_ids and joint_ids in
reset_joints_by_scaleandreset_joints_by_offset.Fixes # 2948
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there