Repository navigation
refactor(router): move WorkerInputs and WorkerInfo to the protocol crate - #129
Closed
ishandhanani wants to merge 1 commit into
Closed
ishandhanani wants to merge 1 commit into
ishandhanani wants to merge 1 commit into
Conversation
ishandhanani
had a problem deploying
to
external_collaborator
October 31, 2026 01:16 — with
GitHub Actions
Failure
Step 5e-0 of the router split (DYNO-178). The column-group bitset a stage component declares (WorkerInputs) and the static facts about a rank every column carries (WorkerInfo: identity plus advertised capacity) move from dynamo-worker-selection to a new columns module in dynamo-router-protocol. Worker selection builds its rows from them and admission's classifier will read workers through them, so neither stage should have to name the other. Worker selection re-exports both, so every existing path in kv-router, lib/llm, and the plugins holds. WorkerInputs::without, which only the composed policy used, is public in its new home. Validation: protocol 10 and worker-selection 41 tests; kv-router 554 + 2 + 7; builtin plugin and lib/llm kv_router 485 tests; clippy clean on the stage crates and lib/llm, mocker, ext-proc, bench; layering gate 22 checks; move-diff 458 common / 1 new / 1 dropped. Signed-off-by: Ishan Dhanani <ishandhanani@gmail.com>
ishandhanani
force-pushed
the
idhanani/dyn-178-inputs-info-to-protocol
branch
from
November 2, 2026 13:30
65578f3 to
12dd91e
Compare
ishandhanani
had a problem deploying
to
external_collaborator
November 2, 2026 13:30 — with
GitHub Actions
Failure
Owner
Author
|
Landed upstream as ai-dynamo#18055 (squash commit 79692cf on main, 2026-11-11). Closing this fork review unit. |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 5e-0 of the router split v2 (DYNO-178). Stacked on #128. A move.
Summary
WorkerInputs(theu8bitset of optional column groups a classifier, filter, scorer, or picker declares;NONE,CACHE,LOAD,PREFERRED_TAINT,OCCUPANCY,KV_TRANSFER,ALL,contains,without,BitOr) andWorkerInfo(a rank's identity and advertisedWorkerCapacity) move fromlib/router/worker-selection/src/inputs.rstolib/router/protocol/src/columns.rs.std::ops::BitOr.WorkerInputs::withoutbecomespub(it waspub(crate); only the composed policy used it). Nothing else changes;dynamo-worker-selectionre-exports both atdynamo_worker_selection::{WorkerInfo, WorkerInputs}, sodynamo_kv_router::plugins::worker_selection::*,dynamo_kv_router::WorkerInputs, and the plugin crates' imports are untouched.Validation
scripts/router_layering_check.sh: 22 checks, 0 failures (protocol's dependency set is unchanged).scripts/router_move_diff.py 280a78532e WORKTREE --from lib/router/worker-selection/src/inputs.rs --to lib/router/worker-selection/src/inputs.rs lib/router/protocol/src/columns.rs: 458 common / 1 new / 1 dropped, the one pair beingpub(crate) fn withoutbecomingpub fn without.