Repository navigation
refactor(router): move the last tier-1 inline paths onto the prelude - #155
Closed
ishandhanani wants to merge 1 commit into
Closed
ishandhanani wants to merge 1 commit into
ishandhanani wants to merge 1 commit into
Conversation
ishandhanani
had a problem deploying
to
external_collaborator
November 1, 2026 04:52 — with
GitHub Actions
Failure
Step 7d-0 of the router split (DYNO-180). The 8a rewrite of the builtin plugin crate missed fully qualified paths whose name is followed by an associated function, a brace, or a comma: twenty sites in its tests, benches, and the thunderagent module still named kv-router's root re-exports and shim modules (DefaultWorkerSelector, SharedCacheHits, WorkerInputs, WorkerLoadProjection, KvSchedulerError, WorkerSelectionPolicy, the kv_hints types, one protocols type, KvRouterConfig). They now name plugins::prelude, the kernel's host module (the reference selector), or config, so that 7d-2 can deprecate the root re-exports without a warning in tree. Validation: kv-router clippy -D warnings --all-targets over seven feature sets (none, full, the standalone aliases, each adapter alone) and its full-feature tests; workspace clippy --all-targets -D warnings (default features); eleven hosts and examples checked alone with --all-targets; Python bindings clippy (kv-indexer, slot-tracker, select-service) and C bindings clippy; cargo hack --each-feature on kv-router (15 configurations); public-api snapshot unchanged (1392 items); layering gate --host 42 checks; codeowners strict; fmt; rustdoc -D warnings on kv-router. Signed-off-by: Ishan Dhanani <ishandhanani@gmail.com>
ishandhanani
force-pushed
the
idhanani/dyn-180-tier1-inline-paths
branch
from
November 2, 2026 13:31
7495ba1 to
64d83d2
Compare
ishandhanani
had a problem deploying
to
external_collaborator
November 2, 2026 13:31 — with
GitHub Actions
Failure
Owner
Author
|
Landed upstream as ai-dynamo#18055 (squash commit 79692cf on main, 2026-11-11). Closing this fork review unit. |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 7d-0 of the router split v2 (DYNO-180). Stacked on #154. The first of three PRs that retire kv-router's shim paths: the tier-1 inline leftovers.
Summary
usestatements and inline paths whose final segment was the item; it skipped fully qualified paths whose name is followed by an associated function, a brace, or a comma. Twenty such sites remained inlib/router-plugins/builtin(tests, benches,thunderagent/mod.rs):dynamo_kv_router::DefaultWorkerSelector::new{,_seeded}(the kernel's reference selector the tests compare against) ->dynamo_scheduler::host::DefaultWorkerSelector;SharedCacheHits::from_ranges,WorkerInputs/::LOAD,WorkerLoadProjection,KvSchedulerError::WorkerSelectionPolicy,WorkerSelectionPolicy::new,kv_hints::{KvTransferCandidates, WorkerKvTransferKeysCache},protocols::KvHintTransferWorkerMetadata->dynamo_kv_router::plugins::prelude::*paths;KvRouterConfig { .. }->dynamo_kv_router::config::KvRouterConfig.Validation
cargo clippy --all-targets -- -D warningsfor none, the full set (http,ingest-zmq,replica-sync-zmq,peer-recovery,metrics,testing), thestandalone-*aliases, and each adapter alone;cargo testunder the full set (225 + 7 + prelude/compat tests).cargo clippy --workspace --all-targets -- -D warnings(default features) clean, so no deprecation or unused-import warning anywhere in tree.cargo check --all-targets):dynamo-llm,dynamo-mocker,dynamo-bench,dynamo-ext-proc,dynamo-custom-policy-builtin,dynamo-worker-selection-policy-catalog,dynamo-sglang-sidecar,dynamo-sglang-mocker,dynamo-vllm-mocker,dynamo-custom-policy-example-soft-pin-repin,dynamo-custom-policy-example-epp; Python bindingscargo clippy --features kv-indexer,slot-tracker,select-service -- -D warnings; C bindings clippy.scripts/router_features_check.sh(cargo hack, 15 configurations);scripts/router_public_api_check.sh: snapshot unchanged (1392 items);scripts/router_layering_check.sh --host: 42 checks, 0 failures; codeowners strict 7530/7530;cargo fmt --all -- --check;RUSTDOCFLAGS="-D warnings" cargo doc -p dynamo-kv-router.