Repository navigation
chore(router): deprecate kv-router's shim paths for one release - #157
Closed
ishandhanani wants to merge 1 commit into
Closed
ishandhanani wants to merge 1 commit into
ishandhanani wants to merge 1 commit into
Conversation
ishandhanani
had a problem deploying
to
external_collaborator
November 1, 2026 06:28 — with
GitHub Actions
Failure
Step 7d-2 of the router split (DYNO-180). dynamo-kv-router is the composition crate: the flat configuration and its parsers, the plugin registry and plugins::prelude, SelectionService and its builder, and the adapters behind features. Every other path it still exposes is a shim over a stage or the kernel, kept so that callers outside this tree have one release to move. Those paths now carry #[deprecated] notes naming the owner: the root re-exports of stage and kernel items, the shim modules (scheduling's kernel re-exports and submodules, protocols, identity, indexer, kv_hints, sequences and its aliases, recovery, worker_type, conditional_disagg, zmq_wire, session_prefix_index, the indexer aliases), and services::selection's kernel re-exports with its TODO(v1.7) compatibility block. Nothing in this tree uses a deprecated path (the workspace builds with -D warnings); the frozen tests/plugin_api_compat.rs and the selection service's HTTP test module (which glob-imports the module) allow them on purpose. Two consequences: the root `queue` and `selector` aliases now name the kernel modules directly instead of the deprecated shim submodules (same paths for every consumer), and the five tests the protocols shim carried for types it only re-exports move verbatim to their owners (protocol's block_hash.rs, worker-selection's shared_cache.rs). The public-api snapshot and the README's path table follow. The standalone-* feature aliases stay one more release, as 7b documented. Validation: kv-router clippy -D warnings --all-targets over seven feature sets and its full-feature tests; workspace clippy --all-targets -D warnings (no deprecation warning anywhere in tree); eleven hosts and examples checked alone with --all-targets; Python and C bindings clippy; cargo hack --each-feature on kv-router (15 configurations); the five relocated tests pass in their owners; public-api snapshot regenerated (1390 items: the two root module aliases change form, no consumer path changes); layering gate --host 42 checks; codeowners strict; fmt; rustdoc -D warnings. Signed-off-by: Ishan Dhanani <ishandhanani@gmail.com>
ishandhanani
force-pushed
the
idhanani/dyn-180-shim-deprecations
branch
from
November 2, 2026 13:31
fb8233a to
81ace25
Compare
ishandhanani
had a problem deploying
to
external_collaborator
November 2, 2026 13:31 — with
GitHub Actions
Failure
ishandhanani
had a problem deploying
to
external_collaborator
November 2, 2026 13:53 — with
GitHub Actions
Failure
Owner
Author
|
Landed upstream as ai-dynamo#18055 (squash commit 79692cf on main, 2026-11-11). Closing this fork review unit. |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 7d-2 of the router split v2 (DYNO-180). Stacked on #156. kv-router's shim paths carry
#[deprecated]for one release; the crate's non-deprecated surface is the composition:config,plugins(withprelude),services(the adapters andSelectionService),tracking_hash, andtest_utils.Summary
since = "1.7.0", each note names the owner and points at the README table): the root re-exports of stage and kernel items (21pub usegroups inlib.rs), the shim modulesconditional_disagg,identity,indexer,kv_hints,protocols,recovery,worker_type, the aliasessequences,session_prefix_index,zmq_wire,concurrent_radix_tree_compressed,nested_map,approx,radix_tree,queue,selector,multi_worker_sequence,sequence; inscheduling, the kernel re-export submodules and lines and the TODO(v1.7) plugin compatibility blocks; inservices::selection, the kernel and session-affinity re-exports and its TODO(v1.7) block;services::overlap.queueandselectorpointed at the deprecatedscheduling::{queue, selector}shim submodules, and rustc lints the path inside a deprecateduse; they now alias the kernel modules directly (pub use dynamo_scheduler::{queue, selector};), so everydynamo_kv_router::queue::X/selector::Xpath still resolves. The snapshot records this as twopub mod+ glob pairs becoming two module aliases (1392 -> 1390 lines; no path a consumer can name changes). (2) Theprotocolsshim carried five tests of types it only re-exports (two block-hash serialization tests, threeSharedCacheHitstests); a deprecated module cannot hold tests (the harness references them), so they move verbatim to their owners,lib/router/protocol/src/block_hash.rsandlib/router/worker-selection/src/shared_cache.rs(two stale comment blocks describing fixtures that had already left this module are dropped).config(the flat configuration, its env readers, the policy YAML forms),pluginsandplugins::prelude,services::{indexer, slot_tracker, selection::{SelectionService, SelectionServiceBuilder, SelectionServiceConfig, warn_for_unserved_worker_selection_policies, local_selection_core, ZmqDirectIngress, AppState, run_server}},tracking_hash,test_utils,scheduling::{config, policy_config}.-D warnings. Two test-only opt-ins: the frozen pre-prelude testtests/plugin_api_compat.rs(#![allow(deprecated)], by design) and the selection service's HTTP test module (#[allow(deprecated)]onmod tests: it glob-imports the module withuse super::*and so reaches the compatibility re-exports; splitting its 1.9k-line import surface is not worth a move-only PR).lib/kv-router/public-api.txtregenerated (the simplified snapshot does not record#[deprecated]; the only change is the alias form above); README gains a "Deprecated paths" table (old path -> owner). Thestandalone-*feature aliases stay one more release as 7b documented;runtime-protocolsis already empty (8f).Validation
cargo clippy --all-targets -- -D warningsfor none, the full set, thestandalone-*aliases, and each adapter alone;cargo testunder the full set.cargo clippy --workspace --all-targets -- -D warnings(default features) clean, so no in-tree code reaches a deprecated path;cargo test -p dynamo-router-protocol block_hash(2) andcargo test -p dynamo-worker-selection shared_cache(3) run the relocated tests in their owners.cargo check --all-targets, which surfaces deprecation warnings per host):dynamo-llm,dynamo-mocker,dynamo-bench,dynamo-ext-proc,dynamo-custom-policy-builtin,dynamo-worker-selection-policy-catalog,dynamo-sglang-sidecar,dynamo-sglang-mocker,dynamo-vllm-mocker, the two examples: none; Python bindingscargo clippy --features kv-indexer,slot-tracker,select-service -- -D warnings; C bindings clippy.scripts/router_features_check.sh(cargo hack, 15 configurations);scripts/router_public_api_check.sh: matches the regenerated snapshot (1390 items);scripts/router_layering_check.sh --host: 42 checks, 0 failures; codeowners strict 7530/7530;cargo fmt --all -- --check;RUSTDOCFLAGS="-D warnings" cargo doc -p dynamo-kv-router.Iterations recorded in the plan: the first pass left the root
queue/selectoraliases pointing at deprecated shim submodules (rustc lints the path inside a deprecateduse) and left five tests inside the deprecatedprotocolsmodule (the test harness references them); both fixed as described above.