Skip to content

Fix: unset permalink for files #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 28 commits into from
Closed
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
184fbdf
Merge pull request #94 from isomerpages/staging
prestonlimlianjie Nov 25, 2019
be4c8e4
Merge pull request #248 from isomerpages/staging
kwajiehao Nov 23, 2020
aaeeb5d
Merge pull request #287 from isomerpages/staging
kwajiehao Dec 23, 2020
eb8e462
Merge pull request #325 from isomerpages/staging
kwajiehao Jan 4, 2021
487997d
Merge pull request #327 from isomerpages/staging
alexanderleegs Jan 5, 2021
a16d726
Merge pull request #423 from isomerpages/develop
alexanderleegs Apr 20, 2021
1b5c9ca
Merge branch 'develop'
alexanderleegs May 10, 2021
3ac5540
Merge pull request #449 from isomerpages/develop
alexanderleegs May 10, 2021
25153ef
Merge pull request #460 from isomerpages/develop
alexanderleegs May 12, 2021
fececb5
Merge pull request #484 from isomerpages/develop
gweiying May 27, 2021
a275f08
Merge pull request #500 from isomerpages/develop
alexanderleegs Jun 3, 2021
47cce2f
Merge pull request #519 from isomerpages/develop
prestonlimlianjie Jun 17, 2021
d242db4
Merge pull request #523 from isomerpages/develop
prestonlimlianjie Jun 18, 2021
f6c4807
Merge pull request #565 from isomerpages/develop
prestonlimlianjie Aug 2, 2021
aad7f83
Merge pull request #574 from isomerpages/develop
alexanderleegs Aug 3, 2021
d534492
Merge pull request #593 from isomerpages/develop
alexanderleegs Aug 12, 2021
992e2c6
Merge pull request #603 from isomerpages/develop
gweiying Aug 19, 2021
e3e9915
Merge pull request #609 from isomerpages/hotfix/dompurify-config
gweiying Aug 24, 2021
98b45b0
Merge pull request #612 from isomerpages/develop
alexanderleegs Aug 26, 2021
c1c3607
Merge pull request #628 from isomerpages/develop
gweiying Sep 16, 2021
80af1d1
Merge pull request #637 from isomerpages/develop
alexanderleegs Sep 23, 2021
9e1ef26
Merge pull request #662 from isomerpages/develop
gweiying Oct 14, 2021
fa9b080
Merge pull request #671 from isomerpages/develop
alexanderleegs Nov 3, 2021
eaf8bb7
Merge pull request #678 from isomerpages/fix/fonts
gweiying Nov 10, 2021
d54b6c0
Merge pull request #692 from isomerpages/develop
alexanderleegs Nov 25, 2021
afbfd11
Merge pull request #704 from isomerpages/develop
alexanderleegs Dec 2, 2021
f64649f
Fix: unset permalink for files
alexanderleegs Dec 13, 2021
4f7c0f8
fix: remove validation
alexanderleegs Dec 13, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/PageSettingsModal/PageSettingsModal.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,13 @@ export const PageSettingsModal = ({
shouldValidate: true,
})
)
if (pageData.content.frontMatter.file_url)
if (pageData.content.frontMatter.file_url) {
// backwards compatible with previous resource files
setValue("layout", "file", {
shouldValidate: true,
})
setValue("permalink", undefined)
}
}
}, [pageData, setValue])

Expand Down