chore(nvmrc): adds nvmrc to pin node version #735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we use a LTS version to guarantee support; 14 is used over 16 because that's the one i've installed. node-sass breaks when node is version 17. this step is also needed for CI to ensure a consistent environment
seaerchin
requested review from
alexanderleegs,
gweiying and
prestonlimlianjie
|
will also do this on the backend repo once approved |
alexanderleegs
approved these changes
Jan 28, 2022
prestonlimlianjie
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Isomer doesn't pin the node version. This might lead to incompatible versioning and unexpected build errors. This occurs when node version is 17 but
node-sassis version 4.xx, where node cannot build the package.Solution
.nvmrcfile. This was preferred as it serves 2 purposes: first, it allows devs developing locally to use the correct version of node, assuming that they have nvm installed; next, it allows netlify to use the.nvmrcto build the site.node-sasswith 17.xx failed, i opted for 14.xx instead.